--MLish and extraction #3142
Merged
--MLish and extraction #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For both compiler and library
--MLish was preventing normalization of lbdefs. Reenable it.
I think I would like this better. And make |
We do not normalize terms for extraction when MLish is on. I think it was intended as a performance benefit for extracting the compiler sources, but maybe it doesn't matter any more. |
Me too. |
…em for dune This eliminates the build race we observed, and seems like a good thing to be able to look at both extractions of a file (in the overlap set of fstarc and fstarlib). `make package` still works.
|
Updated with:
Also FWIW I tried a build of the library without any compiler files, the result is very small, down to 1.7MB from 35M. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to fix the snapshots diffs observed locally. The problem is that some files in ulib (those that the compiler depends on) are extracted twice: once by the extraction of the compiler and once for the library snapshot. Both of these write to the same file, so any discrepancy between them causes a racy build.
I may be forgetting the details of our discussion some time ago but this dual extraction is a bit problematic, first it's repeated work, and second can have these subtle problems.
This PR makes everything extract with --MLish, which works fine after a fix or two.
What I also don't understand is if there's a reason why we extract with --MLish.. why does extraction care? FWIW I tried also disabling --MLish on extraction everywhere and this also works.
@nikswamy @tahina-pro any opinions?