Seq: reimplement seq_to_list and seq_of_list by casting #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Feb 27, 2024
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Mar 4, 2024
tahina-pro
added a commit
to tahina-pro/quackyducky
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the implementations of seq_to_list and seq_of_list much faster (constant time as opposed to linear). There is a bit of refactoring and some new lemmas needed, but everything including everest seems to work (I'll post PRs for subprojects shortly).
For code that makes heavy use of sequences (at the value level) this can make a big difference. Apparently for MLS* it means a performance gain of 50%.
cc @msprotz