Some enhancements in support of interfaces in Pulse #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ging the signature of extension parsers to expose a parse_decl_name function
…pe as the expected type
mtzguido
approved these changes
Apr 28, 2024
src/tactics/FStar.Tactics.Hooks.fst
Outdated
| // See if there is a val for the lid | ||
| // | ||
| if List.length lids > 1 | ||
| then let s = lids |> List.map Ident.string_of_lid |> BU.concat_l ", " in |
There was a problem hiding this comment.
Ah yes, thanks! At some point I was adding this in the error message but then I switched to the show method.
src/tactics/FStar.Tactics.Hooks.fst
Outdated
| (e_tuple3 | ||
| (e_list (e_tuple3 e_bool RE.e_sigelt e_blob)) | ||
| (e_tuple3 e_bool RE.e_sigelt e_blob) | ||
| (e_list (e_tuple3 e_bool RE.e_sigelt e_blob))) |
There was a problem hiding this comment.
Not a big deal but maybe using Typeclasses.solve can fill in these embeddings.
|
I have a local everest green, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the following: