Fixing #3264 #3287
Merged
Fixing #3264 #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can sometimes get a problem like ?u42 = Typeclasses.solve #_ #?u42 which should be trivial if we were to unfold `solve`, but the unifier will not do that automatically, even if `solve` is marked unfold. Instead, an occurs check fails and the unifier reports an error. This patch makes the unifier 1) normalize the RHS a bit more if the occurs check fails, in hope of simplifying it more (in this case, to ?u42) 2) solve the problem if it happens to become trivial after normalization (i.e. ?u42 = ?u42) Fixes FStarLang#3264.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is the important one dbd2138
cc @nikswamy @aseemr @gebner