Tc: rework attribute-tagged implicits to require defer_to #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of picking any attribute to trigger the introduction of a Ctx_uvar_meta_attr, make this so only when `defer_to` is used. This allows us to introduce binder attributes for other things without changing the way they are instantiated.
|
I'll merge this.. I think it's probably fine, but please do let me know if this is incovenient or help is needed migrating. It should just amount to changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of picking any attribute to trigger the introduction of a
Ctx_uvar_meta_attr, make this so only when
defer_tois used. Thisallows us to introduce binder attributes for other things without
changing the way they are instantiated.
This will require a patch to Steel: FStarLang/steel#177
@R1kM: wondering if this seems alright to you. I suppose you may have more code that requires a patch?
This was motivated by noticing that #3406 introduces regressions even without implementing the unrefining logic.