Fix encoding of primitive operators with refined domains #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikswamy
commented
Aug 30, 2024
| @@ -584,7 +584,7 @@ let lemma_lognot_value_zero #n a = | |||
| private | |||
| val lemma_mod_variation: #n:pos -> a:uint_t n -> | |||
| Lemma (a <> 0 ==> ((-a) % pow2 n) - 1 % pow2 n = (((-a) % pow2 n) - 1) % pow2 n) | |||
| let lemma_mod_variation #n a = () | |||
| let lemma_mod_variation #n a = assert (pow2 n =!= 0) | |||
There was a problem hiding this comment.
This proof was a bit flaky and uses a very large rlimit. It seems to stabilizes with this assertion.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3426
This adds preconditions in the SMT encoding to Prims.op_Modulus, op_Division, and Real.op_Slash_dot.
I also had an everest run with no meaningful regressions---one brittle proof in Hacl.Spec.Chacha.Equiv needed a restart-solver to go through.