Extraction.Krml: pretty printing #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
reviewed
Sep 12, 2024
|
|
||
| let showable_from_pretty (#a:Type) {| _ : pretty a |} : Tot (Class.Show.showable a) = { | ||
| show = (fun x -> render (pp x)); | ||
| } |
There was a problem hiding this comment.
Is it an issue that there is a cycle in the type class instances now? Can this cause resolution to loop?
The pretty_from_showable instance also feels a bit dangerous, it makes it easy to accidentally get a nonpretty string even if you call pp.
There was a problem hiding this comment.
They are not instances, so they don't participate in typeclass resolution. They are just normal vals that you can call manually to turn a pretty instance into showable, and viceversa.
There was a problem hiding this comment.
Oh, you're right! I totally missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.