SteelC: Use compat option for running meta args in open ctxs #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After FStarLang/FStar#3130, F* will (by default) not run meta args in open contexts, breaking most SteelC modules. This seems to be very intended for, e.g., field_description_cons, which has no way of instantiating `fn` (when there's no expected type) without running the tactic. Setting this compat option makes everything work as before.
tahina-pro
added a commit
to tahina-pro/quackyducky
that referenced
this pull request
Dec 6, 2023
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Feb 27, 2024
tahina-pro
added a commit
to project-everest/everparse
that referenced
this pull request
Mar 4, 2024
tahina-pro
added a commit
to tahina-pro/quackyducky
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be needed if we merge FStarLang/FStar#3130 as it is right now. Commit message: