chore: add golangci-lint

Signed-off-by: Martin Chodur <[email protected]>

.github/workflows/go.yaml

@@ -18,6 +18,9 @@ jobs:
         with:
           go-version: 1.17
 
+      - name: Golangci-lint
+        uses: golangci/[email protected]
+
       - name: Build
         run: make build
 

Makefile

@@ -18,6 +18,9 @@ $(RELEASE_NOTES): $(TMP_DIR)
 	@mv $(TMP_DIR)/release-notes-part1 $(RELEASE_NOTES)
 	@rm $(TMP_DIR)/release-notes-part*
 
+lint:
+	golangci-lint run
+
 test:
 	go test -race ./...
 

main.go

@@ -113,9 +113,7 @@ func main() {
 			if err != nil {
 				exitWithError(err)
 			}
-			for _, p := range paths {
-				filesToBeValidated = append(filesToBeValidated, p)
-			}
+			filesToBeValidated = append(filesToBeValidated, paths...)
 		}
 
 		validationConfig, err := loadConfigFile(*validateConfigFile)

pkg/report/validation.go

@@ -60,7 +60,7 @@ func ValidationDocs(validationRules []ValidationRule, format string) (string, er
 		})
 	}
 
-	templateToUse := textTemplate
+	var templateToUse string
 	switch format {
 	case "text":
 		templateToUse = textTemplate

pkg/validate/validate.go

@@ -94,9 +94,7 @@ func Files(fileNames []string, validationRules []*ValidationRule, excludeAnnotat
 						}
 					}
 					for _, v := range validationRule.validators {
-						for _, err := range v.Validate(rule) {
-							ruleReport.Errors = append(ruleReport.Errors, err)
-						}
+						ruleReport.Errors = append(ruleReport.Errors, v.Validate(rule)...)
 					}
 					if len(ruleReport.Errors) > 0 {
 						validationReport.Failed = true

pkg/validator/annotations.go

@@ -254,7 +254,6 @@ func newAnnotationIsValidPromQL(paramsConfig yaml.Node) (Validator, error) {
 
 type annotationIsValidPromQL struct {
 	annotation string
-	resolveURL bool
 }
 
 func (h annotationIsValidPromQL) String() string {

pkg/validator/expression.go

@@ -88,21 +88,15 @@ func getExpressionUsedLabels(expr string) ([]string, error) {
 	parser.Inspect(promQl, func(n parser.Node, ns []parser.Node) error {
 		switch v := n.(type) {
 		case *parser.AggregateExpr:
-			for _, m := range v.Grouping {
-				usedLabels = append(usedLabels, m)
-			}
+			usedLabels = append(usedLabels, v.Grouping...)
 		case *parser.VectorSelector:
 			for _, m := range v.LabelMatchers {
 				usedLabels = append(usedLabels, m.Name)
 			}
 		case *parser.BinaryExpr:
 			if v.VectorMatching != nil {
-				for _, m := range v.VectorMatching.Include {
-					usedLabels = append(usedLabels, m)
-				}
-				for _, m := range v.VectorMatching.MatchingLabels {
-					usedLabels = append(usedLabels, m)
-				}
+				usedLabels = append(usedLabels, v.VectorMatching.Include...)
+				usedLabels = append(usedLabels, v.VectorMatching.MatchingLabels...)
 			}
 		}
 		return nil