Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug of yaml marshalling of regexp #8

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fixed bug of yaml marshalling of regexp #8

merged 1 commit into from
Dec 9, 2020

Conversation

neufeldtech
Copy link
Contributor

@neufeldtech neufeldtech commented Dec 8, 2020 •
edited
Loading

  • I ran into a bug where trying to use the regexp validators were not actually working:
Error: loading validator config: yaml: unmarshal errors:
  line 24: cannot unmarshal !!str `^[\w,-]+$` into regexp.Regexp

This PR should fix this for both labels and annotations validators

  • Also fixed up what look like some struct tag typos yam => yaml

FUSAKLA
FUSAKLA approved these changes Dec 9, 2020
View reviewed changes
Copy link
Owner

@FUSAKLA FUSAKLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see I'll need to add some e2e tests covering event loading of the configuration 🙄

Thanks for finding those, I'm not personally using all the validator types, so I must have missed those not working...

@FUSAKLA FUSAKLA mentioned this pull request Dec 9, 2020
Closed
@FUSAKLA FUSAKLA merged commit 9dda959 into FUSAKLA:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FUSAKLA FUSAKLA FUSAKLA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neufeldtech @FUSAKLA