Skip to content

Commit

Permalink
Separate legacy API by moving internals to impl subpackage
Browse files Browse the repository at this point in the history
  • Loading branch information
@sfPlayer1
sfPlayer1 committed Jun 17, 2021
1 parent 5692a30 commit 44c957c
Show file tree
Hide file tree
Showing 135 changed files with 2,106 additions and 1,595 deletions.
2 changes: 1 addition & 1 deletion build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ java {
jar {
manifest {
attributes (
'Main-Class': 'net.fabricmc.loader.launch.server.FabricServerLauncher'
'Main-Class': 'net.fabricmc.loader.impl.launch.server.FabricServerLauncher'
)
}

Expand Down
2 changes: 1 addition & 1 deletion checkstyle.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
</module>

<module name="SuppressionSingleFilter">
<property name="files" value="net[\\/]fabricmc[\\/]loader[\\/]lib[\\/]"/>
<property name="files" value="net[\\/]fabricmc[\\/]loader[\\/]impl[\\/]lib[\\/]"/>
<property name="checks" value=".*"/>
</module>
</module>
Loading

3 comments on commit 44c957c

@Marcono1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the documentation at https://fabricmc.net/wiki/documentation:fabric_loader#launchers have to be adjusted for these changes?

@sfPlayer1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put forwarding methods in place to work around this issue. It'd be a bit early to change the recommendation now since it wouldn't work with older loader versions.

@Marcono1234
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, that makes sense.

Please sign in to comment.