Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot invoke "String.startsWith(String)" when mapping Object.equals in MixinIntermediaryDevRemapper #745

Closed
modmuss50 opened this issue Dec 6, 2022 · 0 comments · Fixed by #746
Assignees
Labels

Comments

@modmuss50
Copy link
Member

modmuss50 commented Dec 6, 2022

When a dependency targets a method on Object such as:@At(value = "INVOKE", target = "Ljava/lang/Object;equals(Ljava/lang/Object;)Z")

MixinIntermediaryDevRemapper throws an NPE when checking if the super name starts with java/.

Loader can easily handle this better but im not convinced this is the fully story, why is there a refmap (I think this only remaps the refmap) entry for Object.equals? Does this fall over elsewhere? Adding remap = false did not help apparently, making things even more confusing 🤔

See discussion on discord: https://discord.com/channels/507304429255393322/807617700734042122/1049744449380548608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant