Fix crash when trying to remap methods in Object. #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfPlayer1
approved these changes
Dec 20, 2022
Juuxel
added a commit
to architectury/architectury-loom-runtime
that referenced
this pull request
Feb 7, 2023
…s in Object. Adapted from Fabric Loader commit 7fde9dc1f94b56bcc796264923b082c2bcfedab2, PR FabricMC/fabric-loader#746. Co-authored-by: modmuss50 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #745
Object has no super class, this fixes a crash when mixin tries to remap
Ljava/lang/Object;equals(Ljava/lang/Object;)ZIm not a massive fan of the use of checking the classname starts with
java/, maybe one to revist when moving to mapping-io?Test mod for future refrence fabric-example-mod-1.0.0.zip (Rename to .jar)