Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resolution errors. #557

Merged
merged 3 commits into from
Nov 27, 2021
Merged

Conversation

sfPlayer1
Copy link
Contributor

This change makes the solver also consider replacing mods that aren't invalid deps for other mods, but have unmet deps themselves.

Mod installation and replacement solutions now provide a proper upper bound and a better lower bound instead of just a somewhat bogus potential version.

Most removal solutions are now instructions to replacing a mod that is compatible with a set of requirements.

This change makes the solver also consider replacing mods that aren't invalid deps for other mods, but have unmet deps themselves.

Mod installation and replacement solutions now provide a proper upper bound and a better lower bound instead of just a somewhat bogus potential version.

Most removal solutions are now instructions to replacing a mod that is compatible with a set of requirements.
@sfPlayer1
Copy link
Contributor Author

old

A potential solution has been determined:
	 - Remove mod 'When Dungeons Arise' (dungeons_arise) 2.1.47-fabric (/path/mods/DungeonsArise-1.17.1-2.1.47-fabric-release.jar).
	 - Replace 'Minecraft' (minecraft) 1.17.1 with 'Minecraft' (minecraft) 1.18-alpha.21.37.a (later versions might work too).
	 - Replace 'OpenJDK 64-Bit Server VM' (java) 16 with 'OpenJDK 64-Bit Server VM' (java) 17 (later versions might work too).
Unmet dependency listing:
	 - Mod 'When Dungeons Arise' (dungeons_arise) requires "version 5.0.0 or later" of cloth-config2, which is missing!
	 - Mod 'Fabric API' (fabric) requires "version 17 or later" of 'OpenJDK 64-Bit Server VM' (java), but only the wrong version is present: 16!
		 - 'OpenJDK 64-Bit Server VM' (java) 16 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric API' (fabric) requires any version between 1.18-alpha.21.37.a (inclusive) and 1.19- (exclusive) of 'Minecraft' (minecraft), but only the wrong version is present: 1.17.1!
		 - 'Minecraft' (minecraft) 1.17.1 is an environment reference and usually requires installation or launcher changes to adjust

new

A potential solution has been determined:
	 - Install cloth-config2, version 5.0.0 or later.
	 - Replace mod 'Fabric API' (fabric) 0.42.7+1.18 (/path/mods/fabric-api-0.42.7+1.18.jar) with any version that is compatible with java 16, minecraft 1.17.1.
Unmet dependency listing:
	 - Mod 'When Dungeons Arise' (dungeons_arise) requires version 5.0.0 or later of cloth-config2, which is missing!
	 - Mod 'Fabric API' (fabric) requires version 17 or later of 'OpenJDK 64-Bit Server VM' (java), but only the wrong version is present: 16!
		 - 'OpenJDK 64-Bit Server VM' (java) 16 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric API' (fabric) requires any version between 1.18-alpha.21.37.a (inclusive) and 1.19- (exclusive) of 'Minecraft' (minecraft), but only the wrong version is present: 1.17.1!
		 - 'Minecraft' (minecraft) 1.17.1 is an environment reference and usually requires installation or launcher changes to adjust

@dexman545
Copy link

java 16, minecraft 1.17.1.
It would improve clarity if there was an "and" before the last element of lists like this.

@sfPlayer1
Copy link
Contributor Author

I changed it to a sub-item-list since the required compatible version listing may now become too complex to fit in a sentence

A potential solution has been determined:
	 - Install cloth-config2, version 5.0.0 or later.
	 - Replace mod 'Fabric API' (fabric) 0.42.7+1.18 (..) with any version that is compatible with:
		 - java 16
		 - minecraft 1.17.1

Adding Optifabric and MC 1.14 yields this:

A potential solution has been determined:
	 - Install cloth-config2, version 5.0.0 or later.
	 - Replace mod 'Fabric Loader' (fabricloader) 0.12.5 (..) with any version between 0.11.3 (inclusive) and 0.12 (exclusive).
	 - Replace mod 'Fabric API' (fabric) 0.42.7+1.18 (..) with any version that is compatible with:
		 - fabricloader, any version between 0.11.3 (inclusive) and 0.12 (exclusive)
		 - java 16
		 - minecraft, version 1.17-alpha.21.8.b, version 1.17-beta.4, version 1.17 or version 1.17.1
	 - Replace 'Minecraft' (minecraft) 1.14 with version 1.17-alpha.21.8.b, version 1.17-beta.4, version 1.17 or version 1.17.1.
Unmet dependency listing:
	 - Mod 'When Dungeons Arise' (dungeons_arise) requires any 1.17.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'When Dungeons Arise' (dungeons_arise) requires version 5.0.0 or later of cloth-config2, which is missing!
	 - Mod 'Fabric API' (fabric) requires version 17 or later of 'OpenJDK 64-Bit Server VM' (java), but only the wrong version is present: 16!
		 - 'OpenJDK 64-Bit Server VM' (java) 16 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric API' (fabric) requires any version between 1.18-alpha.21.37.a (inclusive) and 1.19- (exclusive) of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'OptiFabric' (optifabric) requires any version between 0.8.0 (inclusive) and 0.12 (exclusive) of mod 'Fabric Loader' (fabricloader), but only the wrong version is present: 0.12.5!
		 - Mod 'Fabric Loader' (fabricloader) 0.12.5 is being loaded from ..
	 - Mod 'OptiFabric' (optifabric) requires version 1.16.1, version 1.16.2, version 1.16.3, version 1.16.4, version 1.16.5, version 1.17-alpha.21.8.b, version 1.17-beta.4, version 1.17 or version 1.17.1 of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric Biome API (v1)' (fabric-biome-api-v1) requires version 1.16.2 or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric BlockRenderLayer Registration (v1)' (fabric-blockrenderlayer-v1) requires version 1.15-alpha.19.38.b or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric Dimensions API (v1)' (fabric-dimensions-v1) requires version 1.16-rc.3 or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric Events Interaction (v0)' (fabric-events-interaction-v0) requires version 1.15-alpha.19.37.a or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric Item Groups (v0)' (fabric-item-groups-v0) requires version 1.15- or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust
	 - Mod 'Fabric Renderer API (v1)' (fabric-renderer-api-v1) requires version 1.15-alpha.19.39.a or later of 'Minecraft' (minecraft), but only the wrong version is present: 1.14!
		 - 'Minecraft' (minecraft) 1.14 is an environment reference and usually requires installation or launcher changes to adjust

@sfPlayer1 sfPlayer1 merged commit b81990e into FabricMC:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants