-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve resolution errors. #557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the solver also consider replacing mods that aren't invalid deps for other mods, but have unmet deps themselves. Mod installation and replacement solutions now provide a proper upper bound and a better lower bound instead of just a somewhat bogus potential version. Most removal solutions are now instructions to replacing a mod that is compatible with a set of requirements.
old
new
|
|
I changed it to a sub-item-list since the required compatible version listing may now become too complex to fit in a sentence
Adding Optifabric and MC 1.14 yields this:
|
modmuss50
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the solver also consider replacing mods that aren't invalid deps for other mods, but have unmet deps themselves.
Mod installation and replacement solutions now provide a proper upper bound and a better lower bound instead of just a somewhat bogus potential version.
Most removal solutions are now instructions to replacing a mod that is compatible with a set of requirements.