Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip Log4J2 substitution lookups as necessary #573

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

sfPlayer1
Copy link
Contributor

This should resolve CVE-2021-44228 for all versions.

It first checks if the Log4J version is affected and doesn't react to the system property, then removes the JNDI lookup. Reflection use avoids depending on Log4J core at compile time.

@sfPlayer1 sfPlayer1 changed the title Strip Jndi Lookup as necessary Strip Log4J2 substitution lookups as necessary Dec 10, 2021
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfPlayer1 sfPlayer1 merged commit c826604 into FabricMC:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants