Unbreak EntrypointPatchFML125, again #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, here's a MultiMC instance of a working FML 1.2.5 for Fabric 0.10.8 setup. It even includes a bonus CC0 licensed test mod. This is the last working version of the Fabric Loader currently. If you change it to a newer version in MultiMC, you can observe that it doesn't load. I'll also upload an instance with a custom build of the launcher. |
|
Here's an instance using a build of this PR as the Fabric loader. It's otherwise identical to the previous instance. |
It's almost like only 3 people use this or something
modmuss50
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in c2a0a0e broke EntrypointPatchFML125 due to it now only being able to search for ModClassLoader_125_FML in the game jar files, which doesn't work, as ModClassLoader_125_FML is part of Fabric. I've attempted to get around this by just loading ModClassLoader_125_FML from the launcher's class path.
Disclaimer: I'm not very experienced in using ASM, so this might not be the best way of doing this.