New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't combine resources from the two classloaders in KnotClassLoader.getResources #747

Merged

modmuss50 merged 1 commit into FabricMC:master from modmuss50:getResources_duplicate_fix

Dec 20, 2022

Member

modmuss50 commented Dec 16, 2022

This fixes the Configuration conflict: there is more than one oshi.architecture.properties file on the classpath warning seen in the log file.

I am not 100% sure this fix is correct? Maybe it should de-dupe the resources from the 2 classloaders?


          Don't combine resources from the two classloaders in KnotClassLoader.…

cd98aca

…getResources

modmuss50 added the bug label

modmuss50 requested a review from sfPlayer1

December 16, 2022 19:00

sfPlayer1 approved these changes

View reviewed changes

Contributor

sfPlayer1 left a comment

Should be fine, the original CL isn't supposed to yield anything outside loader.

modmuss50 merged commit 97b8445 into FabricMC:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug