Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and run applet on AWT EventQueue thread #757

Merged
merged 3 commits into from
Feb 18, 2023
Merged

Create and run applet on AWT EventQueue thread #757

merged 3 commits into from
Feb 18, 2023

Conversation

artdeell
Copy link
Contributor

@artdeell artdeell commented Jan 9, 2023

This fixes sometimes occuring race conditions and changes the current behavior to what's suggested by the AWT/Swing documentation

@artdeell
Copy link
Contributor Author

artdeell commented Jan 9, 2023

threaddump-1673190742097.txt
The thread dump describing the problem

@artdeell
Copy link
Contributor Author

nobody even approves...

@TheKodeToad
Copy link

Why not import the EventQueue?

@artdeell
Copy link
Contributor Author

artdeell commented Jan 16, 2023 •
edited
Loading

Why not import the EventQueue?

Because that's how i got netbeans tooltips to show up Because it's only used once

@TheKodeToad
Copy link

In other parts of the code, classes seem to be imported with only one usage.

@modmuss50 modmuss50 merged commit d54566e into FabricMC:master Feb 18, 2023
@GaucovyAero GaucovyAero mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoogieMonster1O1 BoogieMonster1O1 BoogieMonster1O1 approved these changes

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artdeell @TheKodeToad @modmuss50 @BoogieMonster1O1