Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ASCII characters for mod list tree formatting #774

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

NebelNidas
Copy link
Member

MultiMC and its forks apparently don't have Unicode support in their log window, so the mod list dump appears broken:

Broken table formatting

uXFxEr1r

This PR makes the table use ASCII characters instead, so it displays correctly on all systems.

New ASCII-only formatting
[14:15:11] [INFO] [FabricLoader/]: Loading 78 mods:
 - bettersleeping 0.6.0+1.19
    |-- bettersleeping-core 0.6.0
    \-- org_apache_commons_commons-text 1.9
 - cloth-config 9.0.93
    \-- cloth-basic-math 0.6.1
 - fabric-api 0.68.1+1.19.3
    |-- fabric-api-base 0.4.19+8d1895cf72
    |-- fabric-api-lookup-api-v1 1.6.18+49abcf7e72
    |-- fabric-biome-api-v1 12.0.0+689f5e7172
    |-- fabric-block-api-v1 1.0.3+12bfe4ea72
    |-- fabric-blockrenderlayer-v1 1.1.28+c6af733c72
    |-- fabric-client-tags-api-v1 1.0.9+49abcf7e72
    |-- fabric-command-api-v1 1.2.19+f71b366f72
    |-- fabric-command-api-v2 2.1.15+49abcf7e72
    |-- fabric-commands-v0 0.2.36+df3654b372
    |-- fabric-containers-v0 0.1.44+df3654b372
    |-- fabric-content-registries-v0 3.4.11+49abcf7e72
    |-- fabric-convention-tags-v1 1.1.9+2894d6df72
    |-- fabric-crash-report-info-v1 0.2.12+aeb40ebe72
    |-- fabric-data-generation-api-v1 11.0.1+65e415cb72
    |-- fabric-dimensions-v1 2.1.39+48349a3f72
    |-- fabric-entity-events-v1 1.5.5+b83334a072
    |-- fabric-events-interaction-v0 0.4.37+422b77fb72
    |-- fabric-events-lifecycle-v0 0.2.38+df3654b372
    |-- fabric-game-rule-api-v1 1.0.28+2894d6df72
    |-- fabric-item-api-v1 2.1.4+fa25da9972
    |-- fabric-item-group-api-v1 2.1.6+b7096da872
    |-- fabric-key-binding-api-v1 1.0.28+aaaf9d3372
    |-- fabric-keybindings-v0 0.2.26+df3654b372
    |-- fabric-lifecycle-events-v1 2.2.8+2894d6df72
    |-- fabric-loot-api-v2 1.1.17+75e9821172
    \-- fabric-transitive-access-wideners-v1 2.1.0+0efcd39b72
 - fabricloader 0.14.15
 - java 17
 - lazydfu 0.1.3
 - microdurability 0.3.3+1.19
    \-- microdurability-core 0.3.3
 - minecraft 1.19.3
 - minecraft-test 1.0.0
 - modmenu 5.0.0-alpha.4
 - smoothboot 1.19-1.7.1
 - sodium 0.4.5-rc.2
 - starlight 1.1.1+fabric.ae22326
 - testmod 0.3.3+1.19.3
    |-- malilib 0.14.0
    |    \-- fabric-resource-loader-v0 0.10.2+f6c919d672
    |-- toomanybinds-compat-1-19-3 0.3.3
    |    \-- toomanybinds-compat-1-19 0.3.3
    |         \-- toomanybinds-compat-1-18-2 0.3.3
    |              \-- toomanybinds-compat-1-17 0.3.3
    |                   \-- toomanybinds-compat-1-16 0.3.3
    |                        \-- toomanybinds-core 0.3.3
    \-- tweakeroo 0.15.0
 - unsaddle 0.2.1
    |-- unsaddle-compat-1-15 0.2.1
    |-- unsaddle-compat-1-16 0.2.1
    \-- unsaddle-core 0.2.1

Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I don't think its a major downgrade 👍

@modmuss50 modmuss50 linked an issue Feb 22, 2023 that may be closed by this pull request
@modmuss50 modmuss50 added the bug label Feb 22, 2023
@modmuss50 modmuss50 merged commit 48f6ce7 into FabricMC:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tree mod list log doesnt work on all launchers:
4 participants