Update Mixin and build deps #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liach
reviewed
May 5, 2023
| @@ -4,7 +4,7 @@ jobs: | |||
| build: | |||
| strategy: | |||
| matrix: | |||
| java: [8-jdk, 11-jdk, 16-jdk, 17-jdk, 19-jdk] | |||
| java: [8-jdk, 11-jdk, 16-jdk, 17-jdk, 20-jdk] | |||
There was a problem hiding this comment.
Do we keep 16 as minecraft eagerly bumped for records before? I think everything 16 offers is already covered by 17.
There was a problem hiding this comment.
Minecraft has versions that run on JDK 16, I think for now we keep it. In the future I do plan to bump loaders min build version to 17 (While still targgeting 8) so we can remove it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.