Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API method to more easily invoke entrypoints #802

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented May 4, 2023

The functionality in EntryPointUtils is very useful to mods that define their own entrypoints too, since in most situations, they'll want to call them at some point.
This PR adds a public method to FabricLoader that provides the same functionality and removes the static utility class.

@liach
Copy link
Contributor

liach commented May 5, 2023

Should we call it forAllEntrypoints? Since you can define a default method that returns a side-effect-free value. I see the main value as able to call all entrypoints even in cases of exceptions.

@liach liach requested a review from a team May 7, 2023 13:27
@Jab125
Copy link

Jab125 commented Jul 13, 2023

should the EntrypointUtils class be deprecated instead of removed, to avoid mods that might reference fabric's internals?

@sfPlayer1
Copy link
Contributor

No, the impl package is off limits overall. Loom could generate a wildcard discouraging (eclipse only?) or (opt-out) access restriction on fabric impl packages. We may also push more uses of the apistatus annotation.

@shartte
Copy link
Contributor Author

shartte commented Jul 13, 2023

No, the impl package is off limits overall. Loom could generate a wildcard discouraging (eclipse only?) or (opt-out) access restriction on fabric impl packages. We may also push more uses of the apistatus annotation.

One more reason to review and merge this 😈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants