Fix call to findResources returns empty. #837
Conversation
src/main/java/net/fabricmc/loader/impl/launch/knot/KnotClassLoader.java
Outdated
Show resolved
Hide resolved
| public Enumeration<URL> findResources(String name) throws IOException { | ||
| Objects.requireNonNull(name); | ||
|
|
||
| return urlLoader.findResources(name); |
There was a problem hiding this comment.
Should this not also include any results from originalLoader? Or at least if urlLoader doesn't return any results, like getResources does below.
There was a problem hiding this comment.
This current implementation is consistent with findResource(String).
There was a problem hiding this comment.
This current implementation is consistent with findResource(String).
When multiple Models contain resources with the same path, findResource can only display one of them.
There was a problem hiding this comment.
Should this not also include any results from
originalLoader? Or at least ifurlLoaderdoesn't return any results, likegetResourcesdoes below.
My understanding is that findResource and findResources are designed to find resources within the current ClassLoader implementation, while getResource is designed to query the parent ClassLoader and query within the current ClassLoader.
You can see that the findResources implemented by URLClassLoader does not query the results of the parent ClassLoader.
Fix the issue that findResources returns empty due to not overriding findResources.
Added getUrlLoader() to allow developers to access other URLClassLoader methods that are not overridden by KnotClassLoader.