-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify full entrypoint name on crash #928
Conversation
I also dont really know the importance of the |
src/main/java/net/fabricmc/loader/api/entrypoint/EntrypointContainer.java
Outdated
Show resolved
Hide resolved
Before this gets merged, I want to reiterate that I would like to get rid of the Ideally it could just be removed from fabric-loader/src/main/java/net/fabricmc/loader/impl/entrypoint/EntrypointStorage.java Line 107 in 12775fd
as I'm pretty sure the distinction is no longer relevant in this version but you guys probably know more if that marking is still needed. |
I see yes, I dont think thats needed at all. seems fine to remove to me. I need to take a proper look at this exisitng code in an IDE before approving the change. It seems fine on the surface though. |
I think it'd be nicer to keep the current phrasing and only add the location at the end ( |
By all means, I made the PR to be as minimally invasive on the API as possible so I used what was already there. I used the toString because it seems like referencing the entry by a string is implementation specific and not something required by the entrypoint container itself. (also why I opted for entrypoint "name" rather than "definition") |
Added the requested phrasing. I'm pretty sure this does not break api as entrypoint storages are impl. |
Due to the way I use entrypoints in my projects I tend to encounter entrypoint crashes often while developing.
The current logging makes it hard to distinguish which entrypoint is being problematic at a glance.
This small change in fabric loader specifies in the log the exact entrypoint that caused the game to crash.
Essentially changes:
into: