Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D skybox & 2D skybox will not render in RenderViews if the origin is inside the world #6060

Open
marchc1 opened this issue Nov 9, 2024 · 0 comments

Comments

@marchc1
Copy link

marchc1 commented Nov 9, 2024

Details

With a normal camera, going into the world will stop the skybox from rendering completely, as expected...
Image

However, in the case of say a portal, this behavior causes the skybox to not render even though I should be able to see it due to the portal.
Image

Perhaps an additional boolean in ViewData for always rendering the skybox?
If the code is similar to viewrender.cpp, where this check is performed...

if ( ( nSkyboxVisible != SKYBOX_3DSKYBOX_VISIBLE ) && r_3dsky.GetInt() != 2 )
    return NULL;

... could this have an override for if that aforementioned ViewData boolean is set to true? There probably would need to have a check somewhere else too, since, unless the r_3dsky != 2 check is removed from gmod, that did not fix the problem.

Steps to Reproduce

  1. Call render.RenderView with an origin that is in the world
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant