Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization issues: not enough space, localization override from another file, etc. #6096

Open
Satton2 opened this issue Nov 28, 2024 · 2 comments

Comments

@Satton2
Copy link

Satton2 commented Nov 28, 2024

Hello!

Beta branch: NONE / x86-64
Steps to reproduce:

  1. Launch game.
  2. Select any language that is not English.
  3. Go to the Sandbox gamemode,

Details/issues:

  1. Looks like the weapon selector uses the \garrysmod\resource\garrysmod_english.txt to print weapon names instead of the names the in the \garrysmod\resource\localization\<lang>\entities.properties file, which should be changed for every localizable weapon:
    Image
    Image
  2. Looks like GMod's weapons take their names from the same file as above instead of entities.properties but it gets applied in the Weapons tab of the spawn menu too (except for the Physics Gun):
    Image
  3. Localized names of entities, weapons, NPC and vehicles can be a bit or way longer than the original English names. Because of that, some of them get cut off after about 20 characters in the spawn menu tabs (depending on characters, looks like the limit can be bigger), which can lead to some unreadable results.
    Image

It will be great if after reaching the character limit the second line appears, leading to the second part of the text to move below, while the first part gets a bit higher, resulting in a two-line max name. This should be enough for every language and localized names length, since there would be around 15 characters more space (depending on how words will be separated). Such behavior would also probably help some addons that bring new stuff with large names to fit with much more chances and will help those addons that get localized too.
4. The "Save changes" string in the spawn menu (when you try to edit spawnlists) gets misaligned if the text is too long (It's aligned to a bit to the left instead of the center, I guess?):
Image
5. Notifications for picking up some entities are not localized. Specifically ammo and weapons since looks like they take localization from the garrysmod_english.txt:
Image

@robotboy655
Copy link
Contributor

You should not bundle unrelated issues together.

1 & 5 are the same issue really.

2 & 4 will be fixed

@Satton2
Copy link
Author

Satton2 commented Dec 4, 2024

You should not bundle unrelated issues together.

I will remember that. 😉

1 & 5 are the same issue really.

Yeah, I initially thought that they work different, but realized that I was wrong only when was making mentioned PR. ;/

2 & 4 will be fixed

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants