Fill out ParticleSystem a little
#38
Conversation
| /// Useful for particles with intermittent or permanent durations. | ||
| /// </summary> | ||
| [Property] | ||
| public bool EmissionStopped |
There was a problem hiding this comment.
We should flip this so it's just "Emission", default to true
There was a problem hiding this comment.
Updated it 👍
I ran into some situations where setting Emission back to true after disabling it didn't re-enable the particle effect. It seems at some point it's considered finished if the emission is stopped and all the active particles decay.
Not necessarily a problem but it makes me wonder if changing Emission to true should recreate the scene object.
| @@ -26,9 +45,9 @@ public class ParticleSystem : BaseComponent, BaseComponent.ExecuteInEditor | |||
| } | |||
| } | |||
|
|
|||
| [Property] public GameObject ControlPoint0 { get; set; } | |||
There was a problem hiding this comment.
We can't do this, it'll break everything that currently uses it
There was a problem hiding this comment.
I agree it's not ideal but if there was ever a time to break it it'd be now. This feels like something that'd be potentially confusing for newer users later down the line if it isn't changed.
EmissionStoppedproperty onSceneParticlesPlayEffectmethod that just recreates the scene object, as otherwise you need to call OnDisabled() then OnEnabled() to achieve the same effect.