fix: add cluster roles to list and monitor jobs and cronjobs #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add relevant role in order to list jobs-based compute
|
|
|
Thanks for this PR, i need this too |
sudermanjr
approved these changes
Jul 17, 2023
mikutas
added a commit
to mikutas/fairwinds-charts
that referenced
this pull request
Aug 31, 2023
corresponds to FairwindsOps/goldilocks#622
4 tasks
sudermanjr
added a commit
to FairwindsOps/charts
that referenced
this pull request
Sep 5, 2023
corresponds to FairwindsOps/goldilocks#622 Co-authored-by: Andrew Suderman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #
Checklist
Description
What's the goal of this PR?
We get many error logs reporting that the controller can't get/list jobs and cronjobs compute
tasks.
What changes did you make?
add the list/get/watch permission for the controller clusterrole
What alternative solution should we consider, if any?
idk