Pewpew updates20220906 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tkmcmaster
commented
Sep 6, 2022
•
tkmcmaster
commented
- Updated dependencies Cargo and npm
- Fixed clippy and format warnings
- Fixed tests that are failing in Rust 1.63
- Rust version 1.63 changed how they convert float to Durations. Previously they truncated, now they round
- https://github.com/rust-lang/rust/releases/tag/1.63.0
- Use rounding in float to Duration conversion methods rust-lang/rust#96051
- 'Rounding is now used when converting a float to a Duration. The converted duration can differ slightly from what it was.'
- Rust version 1.63 changed how they convert float to Durations. Previously they truncated, now they round
- Fixed the names of some variables to match what they are
- Rust version 1.63 changed how they convert float to Durations. Previously they truncated, now they round - https://github.com/rust-lang/rust/releases/tag/1.63.0 - rust-lang/rust#96051 - 'Rounding is now used when converting a float to a Duration. The converted duration can differ slightly from what it was.'
summersjc
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.