Add requireTypeIdForSubtypes property for JsonTypeInfo.Value, backporting from Jackson 3.0
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JooHyukKim
commented
May 18, 2023
| hashCode = 31 * hashCode + (_requireTypeIdForSubtypes ? 11 : -17); | ||
| hashCode = 31 * hashCode + (_idVisible ? 11 : -17); | ||
| return hashCode; | ||
| } |
There was a problem hiding this comment.
Since baseline is JDK 6, I refered to Objects.hashcode() implementation in JDK7 which internally use Arrays.hashcode()
There was a problem hiding this comment.
I guess we can merge this implementation once more, make master to use this same implementation.
JooHyukKim
commented
May 18, 2023
| return false; | ||
| } | ||
| return value1.equals(value2); | ||
| } |
There was a problem hiding this comment.
Same as,
I guess we can merge this implementation once more, make master to use this same implementation.
Same here also.
cowtowncoder
approved these changes
May 18, 2023
cowtowncoder
added a commit
that referenced
this pull request
May 18, 2023
|
Thank you again @JooHyukKim ! |
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #226