fix the surrogate utf8 feature when custom characterEscapes is used #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
reviewed
Feb 5, 2025
| @@ -20,6 +20,10 @@ a pure JSON library. | |||
| parsing later numbers | |||
| (fix contributed by @pjfanning) | |||
|
|
|||
| #1398: Fix issue that feature COMBINE_UNICODE_SURROGATES_IN_UTF8 doesn't work | |||
There was a problem hiding this comment.
Thank you for updating release notes too! :)
|
@stackunderflow111 First of all, big thank you for providing this pr. I'm happy to merge it, 2.18 branch makes sense as target. One practical thing we need to before merging: if you haven't yet sent CLA (which only needs to be done once before merging the first contribution). CLA is here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and the usual way is to print, fill & sign, scan/photo, email to |
cowtowncoder
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1398
Fixed by applying what I have described in the issue: just port the changes we made in #1335 and #1360 to the two
_writeCustomStringSegment2()methods.