Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Commit

Permalink
Added missing test; added TESTFLAGS
Browse files Browse the repository at this point in the history
  • Loading branch information
yuce authored and jaffee committed May 30, 2018
1 parent dc88b7e commit 85416e7
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ before_install:
- dep ensure
script:
- ./pilosa-master-linux-amd64/pilosa server --metric.diagnostics=false -b https://:20101 -d https_data --tls.skip-verify --tls.certificate test.pilosa.local.crt --tls.key test.pilosa.local.key --cluster.disabled static &
- PILOSA_BIND="https://:20101" make test-all-race
- PILOSA_BIND="https://:20101" make test-all-race TESTFLAGS=-v
- pkill pilosa
- ./pilosa-master-linux-amd64/pilosa server --metric.diagnostics=false -d http_data &
- GOARCH=386 make test-all
- GOARCH=386 make test-all TESTFLAGS=-v
- $HOME/gopath/bin/goveralls -service=travis-ci -ignore "gopilosa_pbuf/public.pb.go" -flags="-tags=integration fullcoverage"
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@ VERSION := $(shell git describe --tags 2> /dev/null || echo unknown)
all: test

cover:
go test -cover -tags="integration fullcoverage"
go test -cover -tags="integration fullcoverage" $(TESTFLAGS)

fast-cover:
go test -cover -tags="integration"
go test -cover -tags="integration" $(TESTFLAGS)

generate:
protoc --go_out=. gopilosa_pbuf/public.proto

test:
go test
go test $(TESTFLAGS)

test-all:
go test -tags=integration
go test -tags=integration $(TESTFLAGS)

test-all-race:
go test -race -tags=integration
go test -race -tags=integration $(TESTFLAGS)

release:
printf "package pilosa\nconst Version = \"$(VERSION)\"" > version.go
3 changes: 3 additions & 0 deletions orm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,9 @@ func TestTopN(t *testing.T) {
comparePQL(t,
"TopN(Bitmap(row=7, frame='collaboration'), frame='sample-frame', n=12, field='category', filters=[80,81])",
sampleFrame.FilterFieldTopN(12, collabFrame.Bitmap(7), "category", 80, 81))
comparePQL(t,
"TopN(frame='sample-frame', n=12, field='category', filters=[80,81])",
sampleFrame.FilterFieldTopN(12, nil, "category", 80, 81))
}

func TestFieldLT(t *testing.T) {
Expand Down

0 comments on commit 85416e7

Please sign in to comment.