This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
prevent nil pointer exception when pilosa cluster does not exist #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client.go
Outdated
| if resp != nil { | ||
| statusCode = resp.StatusCode | ||
| } | ||
| c.logger.Printf("request failed with: %v status: %d, retrying after %d more time(s) after %v ", err, statusCode, tries, sleepTime) |
There was a problem hiding this comment.
Since we're here anyway:
Suggested change
| c.logger.Printf("request failed with: %v status: %d, retrying after %d more time(s) after %v ", err, statusCode, tries, sleepTime) | |
| c.logger.Printf("request failed with: %v status: %d, retrying %d more time(s) after %v ", err, statusCode, tries, sleepTime) |
There was a problem hiding this comment.
quote the '%v' before status as well... that is really confusing — it makes it look the error message ends with the word "status".
(I wrote this code)
There was a problem hiding this comment.
I made those changes
alanbernstein
approved these changes
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.