This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
修改底层grep和find #539
Closed
修改底层grep和find #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new fork
|
@LoRexxar 感谢，晚点我测试下 |
FeeiCN
reviewed
Sep 6, 2017
| logs/ | ||
|
|
||
| # tmp | ||
| tmp/ |
FeeiCN
reviewed
Sep 6, 2017
| @@ -14,10 +14,8 @@ | |||
| import os | |||
| import re | |||
| import json | |||
| import fcntl | |||
| import portalocker | |||
FeeiCN
reviewed
Sep 6, 2017
| @@ -44,34 +42,29 @@ def init_list(self, data=None): | |||
| if not os.path.exists(file_path): | |||
| if isinstance(data, list): | |||
| with open(file_path, 'w') as f: | |||
| fcntl.flock(f, fcntl.LOCK_EX) | |||
| portalocker.lock(f, portalocker.LOCK_EX) | |||
There was a problem hiding this comment.
改为portalocker后，应编写对应的测试用例测试下linux下的兼容性
FeeiCN
reviewed
Sep 6, 2017
cobra/engine.py
Outdated
| raise | ||
| return SingleRule(target_directory, single_rule, files).process() | ||
| except Exception as e: | ||
| traceback.print_exc() |
There was a problem hiding this comment.
异常打印后建议向上层抛出，避免因为某一个规则扫描失败导致整个任务失败
FeeiCN
reviewed
Sep 6, 2017
cobra/file.py
Outdated
| # -*- coding: utf-8 -*- | ||
|
|
||
| """ | ||
| pickup |
FeeiCN
reviewed
Sep 6, 2017
| import logging | ||
| from logging import handlers | ||
| import colorlog |
FeeiCN
reviewed
Sep 6, 2017
| @@ -0,0 +1,472 @@ | |||
|
|
|||
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改底层grep和find，windows支持...部分asl bug