fix: just return components #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're not gonna believe this: String[] can't contain components |
|
|
|
i thought I fixed this |
|
i did not |
yeah so apparently you can just… return them, and figura will handle serializing them for you. fixes 1.21.
PoolloverNathan
force-pushed
the
just-return-components
branch
from
5315bf9 to
8a0d0b9
Compare
|
Why draft |
untested; does it work? |
|
idfk I'ma test it later |
|
works on my machine |
|
works on my machine |
|
oops hit the wrong command from history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yeah so apparently you can just… return them, and figura will handle serializing them for you. fixes 1.21.