nss: look in more locations for cert/key database #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2019
adamdecaf
force-pushed
the
more-nss-locations
branch
from
3b3208d to
a37de73
Compare
FiloSottile
requested changes
Feb 2, 2019
truststore_nss.go
Outdated
| @@ -13,7 +13,7 @@ var ( | |||
| hasNSS bool | |||
| hasCertutil bool | |||
| certutilPath string | |||
| nssDB = filepath.Join(os.Getenv("HOME"), ".pki/nssdb") | |||
| nssDB string | |||
There was a problem hiding this comment.
Was this unused except on Linux? Because now it's only initialized there.
truststore_nss.go
Outdated
| @@ -13,7 +13,7 @@ var ( | |||
| hasNSS bool | |||
| hasCertutil bool | |||
| certutilPath string | |||
| nssDB = filepath.Join(os.Getenv("HOME"), ".pki/nssdb") | |||
| nssDB string | |||
| ) | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
The hasNSS check below on line 21 uses nssDB before it's set.
adamdecaf
force-pushed
the
more-nss-locations
branch
from
a37de73 to
8aa44e0
Compare
|
Apologies for the delay, but I updated the PR. |
|
Hello, I added some feedback on issue : #116 (comment) on my side it does not seem to work |
|
re: #116 (comment) I see what's wrong. The closure isn't running over both paths. func (m *mkcert) forEachNSSProfile(f func(profile string)) (found int) {
profiles, _ := filepath.Glob(FirefoxProfile) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be installs/platforms that don't follow the typical NSS database install location. I don't know how many of these we want to support, so
NSSDB=<path> mkcert -installcould be an option also.Issue: #116 and #120