Build mkcert for arm64 Linux #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
8 tasks
|
I think it would be reasonable to add linux/arm binaries as well. |
rfay
suggested changes
Sep 20, 2020
| @@ -7,6 +7,8 @@ script: | |||
| -ldflags "-X main.Version=$(git describe --tags)" | |||
| - CGO_ENABLED=0 GOOS=linux GOARCH=arm GOARM=6 go build -o "mkcert-$(git describe --tags)-linux-arm" | |||
| -ldflags "-X main.Version=$(git describe --tags)" | |||
| - CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -o "mkcert-$(git describe --tags)-linux-arm64" | |||
| -ldflags "-X main.Version=$(git describe --tags)" | |||
There was a problem hiding this comment.
Suggested change
| -ldflags "-X main.Version=$(git describe --tags)" | |
| -ldflags "-X main.Version=$(git describe --tags)" | |
| - CGO_ENABLED=0 GOOS=linux GOARCH=arm go build -o "mkcert-$(git describe --tags)-linux-arm" | |
| -ldflags "-X main.Version=$(git describe --tags)" | |
There was a problem hiding this comment.
@rfay but arm is already in there right? See above the arm64. Or is that the wrong version?
There was a problem hiding this comment.
Sorry, yes. I didn't even realize that arm was already there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a build for arm64 Linux at the moment. This PR adds support for arm64. More details: https://github.com/golang/go/wiki/GoArm