Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export DivideByZeroError to pub #140

Merged
merged 2 commits into from
Nov 9, 2021
Merged

fix: export DivideByZeroError to pub #140

merged 2 commits into from
Nov 9, 2021

Conversation

brew0722
Copy link
Contributor

@brew0722 brew0722 commented Nov 9, 2021

Description

In StdError like OverflowError, if the struct is positioned as a field, the struct type must also be exposed as pub.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@brew0722 brew0722 self-assigned this Nov 9, 2021
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@brew0722 brew0722 changed the title fix: export DivideByZeroError fix: export DivideByZeroError to pub Nov 9, 2021
loloicci
loloicci approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@loloicci loloicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brew0722 brew0722 merged commit ecdb8eb into Finschia:main Nov 9, 2021
@brew0722 brew0722 deleted the fix_pub_div_zero_err branch November 9, 2021 03:54
@brew0722 brew0722 restored the fix_pub_div_zero_err branch November 9, 2021 04:15
@brew0722 brew0722 mentioned this pull request Nov 9, 2021
Merged
@brew0722 brew0722 deleted the fix_pub_div_zero_err branch November 25, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloicci loloicci loloicci approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

@whylee259 whylee259 whylee259 approved these changes

Assignees

@brew0722 brew0722

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brew0722 @CLAassistant @whylee259 @shiki-tak @loloicci