Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sha1-calculate API and the UUID features (BREAKING CHANGE) #354

Merged
merged 3 commits into from
May 31, 2024

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented May 29, 2024

Description

This PR removes the sha1-calculate API and the UUID feature.
This is because the sha1-calculate API is not supported in the original cosmwasm (CosmWasm/cosmwasm#2119), and we will provide it as another library.

sha1-calculate will return error code 10 to the contract in the wasmvm importing this repository merging PR.
The error code 10 means "a generic error", but it is shown as an error like "Unknown error: 10" in contracts compiled with the former version cosmwasm. sha1-calculate cannot get error messages from the VM with the former version of cosmwasm, so we should tell the breaking change to the users clearly.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this May 29, 2024
@loloicci loloicci merged commit 3b85174 into Finschia:main May 31, 2024
21 checks passed
@loloicci loloicci deleted the remove-uuid branch May 31, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants