Skip to content

Commit

Permalink
fix: refactor queries of x/collection and x/token (#957)
Browse files Browse the repository at this point in the history
* Do not check existence of collection in Query/Balance

* Update CHANGELOG.md

* Revert "Update CHANGELOG.md"

This reverts commit 00b8bc2.

* Revert "Do not check existence of collection in Query/Balance"

This reverts commit 029c26a.

* Revert #956 on x/auth relevant checks

* Add asset check on Query/HoldersByOperator

* Wrap non stateful errors with InvalidArgument

* Revert gRPC errors on page error

* Update CHANGELOG.md

* Increase coverage
  • Loading branch information
0Tech authored Apr 13, 2023
1 parent 88c4242 commit 631ca58
Show file tree
Hide file tree
Showing 12 changed files with 120 additions and 196 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/collection) [\#959](https://github.com/line/lbm-sdk/pull/959) Revert #955 and add Query/HasParent into x/collection
* (x/collection) [\#960](https://github.com/line/lbm-sdk/pull/960) Fix default next class ids of x/collection
* (x/collection) [\#961](https://github.com/line/lbm-sdk/pull/961) Do not loop enum in x/collection
* (x/collection,token) [\#957](https://github.com/line/lbm-sdk/pull/957) Refactor queries of x/collection and x/token

### Removed

Expand Down
4 changes: 2 additions & 2 deletions simapp/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,8 @@ func NewSimApp(
upgrade.NewAppModule(app.UpgradeKeeper),
evidence.NewAppModule(app.EvidenceKeeper),
params.NewAppModule(app.ParamsKeeper),
tokenmodule.NewAppModule(appCodec, app.TokenKeeper, app.AccountKeeper),
collectionmodule.NewAppModule(appCodec, app.CollectionKeeper, app.AccountKeeper),
tokenmodule.NewAppModule(appCodec, app.TokenKeeper),
collectionmodule.NewAppModule(appCodec, app.CollectionKeeper),
authzmodule.NewAppModule(appCodec, app.AuthzKeeper, app.AccountKeeper, app.BankKeeper, app.interfaceRegistry),
)

Expand Down
4 changes: 0 additions & 4 deletions x/collection/expected_keepers.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,4 @@ type (
NewID(ctx sdk.Context) string
HasID(ctx sdk.Context, id string) bool
}

AuthKeeper interface {
HasAccount(sdk.Context, sdk.AccAddress) bool
}
)
Loading

0 comments on commit 631ca58

Please sign in to comment.