Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set order init genesis with lbm-sdk #107

Merged
merged 1 commit into from
Oct 27, 2022
Merged

fix: set order init genesis with lbm-sdk #107

merged 1 commit into from
Oct 27, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Oct 27, 2022 •
edited
Loading

Description

closes: #101

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@dudong2 dudong2 added the bug Something isn't working label Oct 27, 2022
@dudong2 dudong2 self-assigned this Oct 27, 2022
@dudong2 dudong2 requested review from 0Tech, zemyblue, loin3 and tkxkd0159 and removed request for 0Tech October 27, 2022 02:29
zemyblue
zemyblue reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we check if the order is correct?

@dudong2
Copy link
Contributor Author

dudong2 commented Oct 27, 2022

How can we check if the order is correct?

There's no way to check this, and I don't think it's necessary. This is because the order can be changed at any time as intended.

@dudong2 dudong2 requested a review from zemyblue October 27, 2022 03:46
@dudong2 dudong2 merged commit e774fd3 into main Oct 27, 2022
@dudong2 dudong2 deleted the dudong2/fix/order-init-genesis branch October 27, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@0Tech 0Tech 0Tech approved these changes

@loin3 loin3 Awaiting requested review from loin3

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

Assignees

@dudong2 dudong2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module initialization order in init genesis
3 participants
@dudong2 @zemyblue @0Tech