Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update tag github action #185

Merged
merged 3 commits into from
May 16, 2023
Merged

ci: update tag github action #185

merged 3 commits into from
May 16, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 10, 2023 •
edited
Loading

Description

closes: #184

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@zemyblue zemyblue self-assigned this May 10, 2023
@CLAassistant
Copy link

CLAassistant commented May 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zemyblue
chore: update changelog
4c6bd5b 
Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue marked this pull request as ready for review May 11, 2023 02:59
@zemyblue zemyblue added this to the v1.1.0 milestone May 11, 2023
loin3
loin3 reviewed May 12, 2023
View reviewed changes
Copy link

@loin3 loin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sims.yml and lint.yml still use secrets.TOKEN.
Don't we need to change these?

@zemyblue
Copy link
Member Author

sims.yml and lint.yml still use secrets.TOKEN.
Don't we need to change these?

I changed all TOKEN

@zemyblue zemyblue requested a review from loin3 May 15, 2023 01:25
@zemyblue zemyblue merged commit 6ccefec into Finschia:main May 16, 2023
@zemyblue zemyblue deleted the feat/fix_tag_ci branch May 18, 2023 05:32
@zemyblue zemyblue removed this from the v1.1.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loin3 loin3 loin3 approved these changes

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

@dudong2 dudong2 Awaiting requested review from dudong2

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github tag.yml action not work
4 participants
@zemyblue @CLAassistant @loin3 @jaeseung-bae