-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bazel build and add a GitHub action to exercise the build on different platforms #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Overall this looks great, just a couple of nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
My only remaining comment is to expand the PR name to be a little more descriptive. I went ahead and renamed it for faster turnaround -- please let me know if you'd prefer any changes (the PR name can be changed even when it's merged).
This is an extended branch from https://github.com/KimuraYu45z/protobuf-rules-gen/tree/master
so plz see #42 at first.
In this branch, I wrote the github actions workflow to emit the built binary files across platform matrix.
This can help M1 mac users and so on.