Add 8.4 stable and 8.5-dev to test matrix #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
=========================================
Coverage 81.26% 81.26%
Complexity 308 308
=========================================
Files 33 33
Lines 1025 1025
=========================================
Hits 833 833
Misses 192 192 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 was released last week, so this updates the test matrix accordingly. 8.1 can be reasonably dropped as well.
8.4 and 8.5 are now emitting a deprecation warning from the ASN.1 library. I intend to send a PR, but there's been no activity for quite some time (understandable given the context of the library, but there's also an open PR for other language-related improvements) so switching to a more actively-maintained library may end up being a better choice.