A few small formatting and commenting fixes to finish the PR

Flagsmith · Feb 27, 2024 · 08fa2ce · 08fa2ce
1 parent 6bd22fc
commit 08fa2ce
Show file tree

Hide file tree

Showing 14 changed files with 237 additions and 230 deletions.
diff --git a/Example/FlagsmithClient/AppDelegate.swift b/Example/FlagsmithClient/AppDelegate.swift
@@ -53,13 +53,13 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
       print(result)
     }
 
-    // Try getting the feature flags concurrently
-    for concurrentIteration in 1...20 {
-        concurrentQueue.async {
-          Flagsmith.shared.getFeatureFlags() { (result) in
-            print("Concurrent \(concurrentIteration) result success: \(isSuccess(result)) on \(Thread.current)")
-          }
+    // Try getting the feature flags concurrently to ensure that this does not cause any issues
+    // This was originally highlighted in https://github.com/Flagsmith/flagsmith-ios-client/pull/40
+    for _ in 1...20 {
+      concurrentQueue.async {
+        Flagsmith.shared.getFeatureFlags() { (result) in
         }
+      }
     }
 
     //Flagsmith.shared.setTrait(Trait(key: "<my_key>", value: "<my_value>"), forIdentity: "<my_identity>") { (result) in print(result) }

diff --git a/Example/Podfile.lock b/Example/Podfile.lock
@@ -1,5 +1,5 @@
 PODS:
-  - FlagsmithClient (1.1.2)
+  - FlagsmithClient (3.4.0)
 
 DEPENDENCIES:
   - FlagsmithClient (from `../`)
@@ -9,8 +9,8 @@ EXTERNAL SOURCES:
     :path: "../"
 
 SPEC CHECKSUMS:
-  FlagsmithClient: dd72c22b356fe008aaec4a7069e88579c3b7d979
+  FlagsmithClient: 0f8ed4a38dec385d73cc21a64b791b39bcc8c32b
 
 PODFILE CHECKSUM: 9fc876dee0cf031cae843156b0740a94b4994d8c
 
-COCOAPODS: 1.11.2
+COCOAPODS: 1.13.0
diff --git a/Example/Pods/Local Podspecs/FlagsmithClient.podspec.json b/Example/Pods/Local Podspecs/FlagsmithClient.podspec.json
diff --git a/Example/Pods/Manifest.lock b/Example/Pods/Manifest.lock
diff --git a/Example/Pods/Pods.xcodeproj/project.pbxproj b/Example/Pods/Pods.xcodeproj/project.pbxproj
diff --git a/Example/Pods/Target Support Files/FlagsmithClient/FlagsmithClient-Info.plist b/Example/Pods/Target Support Files/FlagsmithClient/FlagsmithClient-Info.plist
diff --git a/Example/Pods/Target Support Files/FlagsmithClient/FlagsmithClient.debug.xcconfig b/Example/Pods/Target Support Files/FlagsmithClient/FlagsmithClient.debug.xcconfig
diff --git a/Example/Pods/Target Support Files/FlagsmithClient/FlagsmithClient.release.xcconfig b/Example/Pods/Target Support Files/FlagsmithClient/FlagsmithClient.release.xcconfig
diff --git a/...Target Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example-Info.plist b/...Target Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example-Info.plist
diff --git a/...get Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example-frameworks.sh b/...get Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example-frameworks.sh
diff --git a/...et Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example.debug.xcconfig b/...et Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example.debug.xcconfig
diff --git a/... Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example.release.xcconfig b/... Support Files/Pods-FlagsmithClient_Example/Pods-FlagsmithClient_Example.release.xcconfig
diff --git a/FlagsmithClient/Classes/Internal/APIManager.swift b/FlagsmithClient/Classes/Internal/APIManager.swift
@@ -23,7 +23,7 @@ class APIManager : NSObject, URLSessionDataDelegate {
   // store the completion handlers and accumulated data for each task
   private var tasksToCompletionHandlers:[Int:(Result<Data, Error>) -> Void] = [:]
   private var tasksToData:[Int:Data] = [:]
-    private let serialAccessQueue = DispatchQueue(label: "flagsmithSerialAccessQueue")
+  private let serialAccessQueue = DispatchQueue(label: "flagsmithSerialAccessQueue")
 
   override init() {
     super.init()

diff --git a/FlagsmithClient/Tests/APIManagerTests.swift b/FlagsmithClient/Tests/APIManagerTests.swift
@@ -80,5 +80,6 @@ final class APIManagerTests: FlagsmithClientTestCase {
         }
 
         wait(for: expectations, timeout: 5)
+        print("Finished!")
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,5 +80,6 @@ final class APIManagerTests: FlagsmithClientTestCase { @@
             }
             wait(for: expectations, timeout: 5)
+            print("Finished!")
         }
     }