Simplified Analytics References #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates how the
Analyticsclass is referenced. There were multiple instances of cross-referencing singletons:Flagsmith>FlagsmithAnalyticsFlagsmithAnalytics>Flagsmith.This PR simplifies the implementation by removing the
sharedanalytics instance, and in place directly instantiates an analytics reference in the mainFlagsmithclass. This now functions much more like theAPIManager. Since analytics requires access to the api, the a reference is passed through the initializer.Also addressed is the line indentations to match the rest of the codebase.