Use data and lock #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After two weeks of observation, I can state that it fixes our crashes on production. Please take a look at it, since we want to drop an internal fork. cc @dabeeeenster |
|
We're going to write some unit tests around this first I think! |
7 tasks
|
I think this can be closed as superseded by #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSMulatbleDatatoDatafinalclassNSLockinstance to the APIManager class to synchronize access to shared resources. Swift dictionary is not thread-safe and accessing it from singleton instance (Flagsmith.shared) can lead to race conditions.