Updated strict concurrency and Privacy Manifests #50
Conversation
- Enabled `StrictConcurrency=complete` mode in order to be prepared for upcoming Swift 6. Implemented `Sendable` support for Flagsmith client and friends. - Enabled `ExistentialAny` feature in order to be prepared for upcoming Swift 6. Code adjustments - adjusted tests for `StrictConcurrency=complete` mode .
…agsmith#48) * - Bumped `swift-tools` to swift 5.9. - Enabled `StrictConcurrency=complete` mode in order to be prepared for upcoming Swift 6. Implemented `Sendable` support for Flagsmith client and friends. - Enabled `ExistentialAny` feature in order to be prepared for upcoming Swift 6. Code adjustments - adjusted tests for `StrictConcurrency=complete` mode . * adjusted macOS runner * cleanup
…/strict-concurency
|
Yep the Privacy Manifest stuff LGTM here. |
…e runners to check everything is fine
There was a problem hiding this comment.
I've added a couple of comments on the privacy manifest, but I'm a little confused why this PR seems to include t2o totally distinct things. I'm not sure why we merged the strict concurrency PR into a branch to then add the manifest to as well.
I guess my main concern is that the description of the PR references the changes to the privacy manifest but mentions nothing about any testing that has been carried out on what seem like fairly hefty changes on the actual SDK.
| <false/> | ||
| <key>NSPrivacyCollectedDataTypePurposes</key> | ||
| <array> | ||
| <string>NSPrivacyCollectedDataTypePurposeAnalytics</string> |
There was a problem hiding this comment.
I'd say this should actually be
| <string>NSPrivacyCollectedDataTypePurposeAnalytics</string> | |
| <string>NSPrivacyCollectedDataTypePurposeAppFunctionality</string> |
We're collecting analytics data to enable analytics graphs in our customer's dashboard, not for our own purposes.
| <key>NSPrivacyTracking</key> | ||
| <true/> |
There was a problem hiding this comment.
I'm not sure this is true is it?
|
Superseded by #55 |
This PR supersedes and includes #48.
This PR updates the above by also updating the Cocoapods functionality to match the Swift Package Manager changes above: 6b5dc80
Due to upcoming https://developer.apple.com/support/third-party-SDK-requirements/ we've updated the SDK to include a Privacy Manifest.
The format and purpose of these is described here: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files
The crux of what I've gone for on here is:
UserDefaults: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api#4278401
This is needed to store persistent state info for the SDK. At the moment this is just used to store analytics events in the case they can't be sent immediately. This could possibly be removed in the future if you're (a) not that fussed and we (b) post analytics when the app goes to the background to avoid data loss.
Other Diagnostic Data:
from here: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests#4144131
The release is set up to be version 3.6.0 in the Podspec.
I've tested this with the unit tests and also creating local packages with Swift Package Manager and Cocoapods to see if the Privacy Manifest is included, which it does appear to be. When running the new SDK in the example app I didn't see any additional privacy dialogs appear.
I've also checked my changes against other popular iOS SDKs and can confirm they're consistent.
Manifest files are typically checked by Apple automatically when submitting to the App Store, so that's going to be the real test for this one.
Type of Change