Ci/add swift lint and swiftformat #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal keyword from the Trait, format all the files in the SDK
matthewelwell
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continued @matthewelwell 's work to add swiftlint to the PR pipleline to enforce code style. This ended up in a bit of a rabbit hole of warnings and errors, as these things do when you add them to an existing codebase.
I'm happy with the code style now. It's nice.
I've configured swiftlint and swiftformat so that they can be run simultaneously and not complain at each other.
I've updated our code where required to fit the standard swiftlint config, while relaxed a little on some of the more pedantic rules that might make things a pain for contributors.
Type of Change