feat: Identity overrides in local evaluation mode #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store environment-supplied identity overrides - Use stored identity overrides in local evaluation mode - Remove integration configurations from `EnvironmentModel`
khvn26
requested review from
a team and
novakzaballa
and removed request for
a team
This was referenced Jan 30, 2024
Comment on lines
63
to
69
| if (identityOverrides != null) { | ||
| Map<String, IdentityModel> identityOverridesByIdentifier = new HashMap<>(); | ||
| for (IdentityModel identity : identityOverrides) { | ||
| identityOverridesByIdentifier.put(identity.getIdentifier(), identity); | ||
| } | ||
| this.identityOverridesByIdentifier = identityOverridesByIdentifier; | ||
| } |
There was a problem hiding this comment.
Similar comment here to the one I added to the node.js repo here: Flagsmith/flagsmith-nodejs-client#143 (comment)
There was a problem hiding this comment.
As per discussion in Node.js client, let's update the name of this variable here too.
matthewelwell
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to Flagsmith/flagsmith#3132.
EnvironmentModelIdentityModel.identity_featurestype fromSettoListto fix equality checks for identities. It seems that using aHashSetthere initially was a mistake, as theFeatureStateModelclass did not havehashCodeimplemented becauseequalswas overridden (at least, I didn't observe thehashCodedefinition after delomboking in IDEA). Moreover, definingFeatureStateModel.hashCodeis tricky as its collections need different deduplication in different contexts.