-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(task-processor): validate arguments passed to task processor functions #2747
feat(task-processor): validate arguments passed to task processor functions #2747
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2747 +/- ##
=======================================
Coverage 95.48% 95.49%
=======================================
Files 993 993
Lines 27931 27967 +36
=======================================
+ Hits 26669 26706 +37
+ Misses 1262 1261 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Validates the inputs to tasks when running synchronously or in a separate thread. Primary use case for this is to catch errors with serialization before going into production.
How did you test this code?
Added unit tests. Also, all existing calls to the task processor should subsequently be validated in the unit tests.